feat(mcp): Prefix tool names with client name to avoid naming conflicts #2436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| McpSchema.Implementation clientInfo = new McpSchema.Implementation(commonProperties.getName(), | ||
| commonProperties.getVersion()); | ||
| McpSchema.Implementation clientInfo = new McpSchema.Implementation( | ||
| commonProperties.getName() + " - " + namedTransport.name(), commonProperties.getVersion()); |
There was a problem hiding this comment.
It would be good to move this logic to a method for reusability and consistency across.
There was a problem hiding this comment.
sure. It is addressed
Enhances MCP tool naming by prefixing tool names with their client + transport name to prevent conflicts when multiple MCP clients expose tools with the same name. - Modifies client info in McpClientAutoConfiguration to include transport name - Updates SyncMcpToolCallback and AsyncMcpToolCallback to prefix tool names with client + transport name - Adds test coverage for tools with identical names but different client info Resolves spring-projects#2393 Signed-off-by: Christian Tzolov <[email protected]>
tzolov
force-pushed
the
mcp-tool-name-auto-prefix
branch
from
78afac9 to
9571501
Compare
|
Rebased and merged as 9571501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances MCP tool naming by prefixing tool names with their client + transport name to prevent conflicts when multiple MCP clients expose tools with the same name.
Resolves #2393